Bugfixing and evaluation cycle started
| GHengeveld |
|
|---|---|
|
Done in 1782
|
| esclkm |
|
|---|---|
|
WTF?
if you do something fast it can be not good strreplace - it is not good replacement littledev.ru - мой маленький зарождающийся блог о котонти.
снижение стоимости программирования и снижение стоимости производства разные вещи. Первое можно скорее сравнить с раздачей работникам дешевых инструментов, чем со снижением зарплаты |
| GHengeveld |
|
|---|---|
|
Improve upon it then
 Added 16 hours 40 minutes later: Done some research into fastest string replacement method. sprintf would be the fastest, but isn't applicable in this case. Only strtr would be an alternative worth considering. It turns out str_replace is faster when working with arrays of words. See http://www.cznp.com/blog/3/strtr-vs-str_replace-a-battle-for-speed-and-didignity An alternative would be to not use string replacement on the end result, but on the format, replacing textual format indicators with their numbered counterparts, and use the returned numbers as index in the array of words. This does require a few more steps, so I doubt it will be faster in the end. If speed is an issue, this might be worth a try, but I think str_replace is fast enough. |
|
| This post was edited by Koradhil (2011-01-29 17:42, 13 years ago) |
| Trustmaster |
|
|---|---|
|
Well, if you used a different array name (e.g. $Ldate) with keys as search values and values as replacement, you could do it just with 1 line with strtr. Another thing: if $lang == 'en' then you needn't apply the replacement. And finally the biggest problem about this function is grammar. It is not any obvious for languages like English, but I'll give you a few examples of Russian translations:
May the Source be with you!
|
| GHengeveld |
|
|---|---|
|
In consultation with Trustmaster we decided to use 20 predefined formats for date and time. These will be defined in the main language file so grammar can be different between languages and the formats can be overridden by plugins or templates. Aside from these formats, it will also be possible to use custom formats, although those will not be modifiable in terms of grammar. Month and day names will still be translated.
The 20 formats are defined here. |
| Trustmaster |
|
|---|---|
|
The upgrade script now saves sorting order for existing categories (r1784).
Also fixed subforum paths during upgrade and subforum output. Though some subforum paths may still be wrong because of the bug in Genoa which puts subforums into right masterforum but wrong section, such cases are easy to fix in Admin => Forums => Categories manually after upgrade. May the Source be with you!
|
| pieter |
|
|---|---|
|
If I want to upgrade from a beta version to a new version of the beta.
Is it possible, Do I need to start from zero? ... can we help you ...
|
| Trustmaster |
|
|---|---|
|
Normally you just need to run install.php and it will apply patches between your revision and last revision. But if you mean changes made to upgrade script (from Genoa), then the upgrade should be performed from scratch (from Genoa to Siena again), because the patches like in the post above use data which is lost after upgrade is finished.
May the Source be with you!
|
| pieter |
|
|---|---|
|
I copied the new trunk version to my site and ran install.pgp.
Fatal error : SQL error HY000: General error: 2014 Cannot execute queries while other unbuffered queries are active. Consider using PDOStatement::fetchAll(). Alternatively, if your code is only ever going to run against mysql, you may enable query buffering by setting the PDO::MYSQL_ATTR_USE_BUFFERED_QUERY attribute. http://www.broens.be/install.php ... can we help you ...
|
| GHengeveld |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
Okay, I just committed the change to cot_date. There are now 20 predefined formats available:
They can be used like this: {LIST_ROW_BEGIN_STAMP|cot_date('date_full', $this)} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| This post was edited by Koradhil (2011-01-30 21:55, 13 years ago) |
| Trustmaster |
|
|---|---|
# pieter : I copied the new trunk version to my site and ran install.pgp.Yes, with more verbose error reporting now we see that PDO is not used properly. For SELECT queries either all results must be fetched or a cursor must be closed. I'll be fixing that, it may take a while. I'd like to draw a line, because Feb 1st is approaching. Obviously, 0.9.0 is not going to be released on Feb 1st because of several critical bugs:
May the Source be with you!
|
| pieter |
|
|---|---|
|
I reinstalled and got some errors after upgrade.
Was not a problem last time. When adding a comment: Fatal error : SQL error 42S22: Column not found: 1054 Unknown column 'com_area' in 'field list' Added 24 minutes later: If I click on in admin: configuration - main settings I get a more or less blank page. And the link is: http://www.broens.be/admin.php?m=config#get;admin.php;m=config&n=edit&o=core&p=main Also on the other parts of configuration. In the middle there is something wrong. ---------------------- Update: All comments that were there before the upgrade are gone. ---------------------- ---------------------- ... can we help you ...
|
|
| This post was edited by pieter (2011-01-31 02:06, 13 years ago) |
| Trustmaster |
|
|---|---|
|
Fixed some PDO-related bugs. Comments are broken during upgrade, will fix it soon.
May the Source be with you!
|
| pieter |
|
|---|---|
# pieter : Pls check also admin menu. ... can we help you ...
|
| GHengeveld |
|
|---|---|
|
Can you try disabling AJAX ? Also, provide some more info. I was unable to reproduce this.
|
