[HELP][WIP] Plugin: User Comments

Tags: Usercomments Plugin

musiconly	#1 2009-10-25 04:38
Contributors	I caught some god damn cold and I'm stuck at home on saturday night Anyways, I decided to use it for a learning session. I'm trying to create a plugin which I called User Comments. Features: Show user comment count on user profile(hook: users.details.main) Show last X comments on user profile(hook: users.details.main) Show all comments from this user(standalone) Top commentators(probably standalone) I got stuck!!! <?PHP /* ==================== [BEGIN_SED_EXTPLUGIN] Code=usercomments Part=user File=usercomments.user Hooks=users.details.tags Tags=users.details.tpl:{USERS_DETAILS_COMCOUNT} Order=10 [END_SED_EXTPLUGIN] ==================== / /* * Part of plug UserComments * * @package Cotonti * @version 0.6.4 * @author MusicOnly * @copyright All rights reserved. 2008-2009 * @license BSD / defined('SED_CODE') or die('Wrong URL'); /---------------------------- ----Comment Count------- ----------------------------/ $sql1 = sed_sql_query("SELECT FROM $db_com WHERE com_authorid = $id"); $noc = sed_sql_numrows($sql1); /----------------------------------------- -----Display all user comments------ ----------------------------------------/ $sac = "<a href='/plug.php?e=usercomments&ui=$id'>".$noc."</a>"; $t->assign('USERS_DETAILS_COMCOUNT', $sac ); ?> <?PHP /* ==================== [BEGIN_SED_EXTPLUGIN] Code=usercomments Part=main File=usercomments Hooks=standalone Tags= Order= [END_SED_EXTPLUGIN] ==================== / /* * List of all user comments ever made * * @package Cotonti * @version 0.6.4 * @author MusicOnly * @copyright Copyright (c) Cotonti Team 2008-2009 * @license BSD / defined('SED_CODE') && defined('SED_PLUG') or die('Wrong URL'); $t = new XTemplate(sed_skinfile('usercomments', true)); $sql2 = sed_sql_query("SELECT FROM $db_com WHERE com_authorid = '$ui'"); while($row = sed_sql_fetcharray($sql2)) { $t->assign(array( 'UC_ROW_CID' => $row['com_id'], 'UC_ROW_CC' => $row['com_code'], 'UC_ROW_CAI' => $row['com_authorid'], 'UC_ROW_CA' => $row['com_author'], 'UC_ROW_CT' => $row['com_text'], 'UC_ROW_CD' => $row['com_date'] )); $t->parse('MAIN.UC_ROW'); } ?> <!-- BEGIN: MAIN --> <div id="fullpage"> You look like you did before </div> <!-- BEGIN: UC_ROW --> {UC_ROW_CID} - {UC_ROW_CC} - {UC_ROW_CAI} - {UC_ROW_CA} - {UC_ROW_CT} - {UC_ROW_CT} - {UC_ROW_CD} <br /> <!-- END: UC_ROW --> <!-- END: MAIN --> I got the count part working It shows total count of user comments and when you click on that number it takes you to /plug.php?e=usercomments&ui=USERID. I can only see the content of div "You look like you did before", but no ROW data? What did I miss? I'm reading Koradhil's tutorial on plugins Thanks

musiconly

#1 2009-10-25 04:38

I caught some god damn cold and I'm stuck at home on saturday night

Anyways, I decided to use it for a learning session.

I'm trying to create a plugin which I called User Comments.

Features:

I got stuck!!!

I got the count part working

It shows total count of user comments and when you click on that number it takes you to /plug.php?e=usercomments&ui=USERID.
I can only see the content of div "You look like you did before", but no ROW data?

What did I miss?
I'm reading Koradhil's tutorial on plugins

Thanks

GHengeveld	#2 2009-10-25 05:58
Team Thanked: 52 times	You need to import the $ui variable from GET, otherwise your query won't work. Also it's better to cast or check any variables used in an SQL query. Integers should be cast using (int)$variable and strings need to be prepped using sed_sql_prep(). Another minor detail is that you shouldn't put quotes around an integer, since that would require it to be converted from string to integer. Try this: $ui = sed_import('ui', 'G', 'INT'); $sql2 = sed_sql_query("SELECT * FROM $db_com WHERE com_authorid=".(int)$ui); For the rest of it, it's looking good, keep it up. Glad to see my guide gets used too
This post was edited by Koradhil (2009-10-25 06:06, 14 years ago)

GHengeveld

#2 2009-10-25 05:58

Team
Thanked: 52 times

You need to import the $ui variable from GET, otherwise your query won't work. Also it's better to cast or check any variables used in an SQL query. Integers should be cast using (int)$variable and strings need to be prepped using sed_sql_prep(). Another minor detail is that you shouldn't put quotes around an integer, since that would require it to be converted from string to integer.
Try this:

$ui = sed_import('ui', 'G', 'INT');
$sql2 = sed_sql_query("SELECT * FROM $db_com WHERE com_authorid=".(int)$ui);

For the rest of it, it's looking good, keep it up. Glad to see my guide gets used too

This post was edited by Koradhil (2009-10-25 06:06, 14 years ago)

musiconly	#3 2009-10-25 19:30
Contributors	Thanks Koradhil for a great explanation Now I finally get that sed_import part (I always wondered where it's used). I'm not a PHP programmer (C++ is my playground), but I forced myself to learn it because of some mods/plugs that I'll need for my website. If I get stuck on another thing, I'll post it here