Reduced thumbnail generation functionality

Hodges

#37357 03.04.2013 15:34

Good afternoon,

So as you guys are probably aware I've been doing Genoa -> Siena upgrade these past few weeks (hence all the random posts). One thing I've noticed, however, is the thumbnail generation seems to have been somewhat crippled.

PHP

        
              //old:
sed_createthumb(original path, thumbnail path, x dim, y dim, keepratio, filetype, file, filesize, color text, bg color, border, jpeg quality, dim priority)
 
//new:
cot_imageresize(original path, thumbnail path, x dim, y dim, 'fit', bg color, jpeg quality)

The first problem is that the Siena PFS config file still teases the user with lots of customisation options that the function itself doesn't even use! Even if I could forgive that my real gripe would have to be that my images are being cropped. I'd rather have "transparent letterboxing".

I think the thumbnail settings should be:

Maximum width and maximum height are one setting, one number, eg: 250px. and it is never exceeded!
Aspect ratio = always maintained;
Cropping: never crop.
If both width and height are less than max dim then do nothing to the image.

If Cotonti could allow me to use these settings on thumbnails that would be magic.

Discuss! :)