cotonti.com : Some enhancement for list.php

Kilandor

Ср, 17 Вер 2008 14:31:14 -0000

Correct I think would be best to pull anything that has hardcoded names like that out, or if for some reason we can't, make them configurable.

Trustmaster

Ср, 17 Вер 2008 00:57:33 -0000

Feel free to commit it to trunk. But for longer term, we want to put all icons outta core, don't we?

Orkan

Вт, 16 Вер 2008 01:25:40 -0000

ahh, yes :)

haha! The power of Arrays !!!

$sed_img_active['asc'] = "";
$sed_img_active['desc'] = "";

$arrows = array();
$params = array('title','key','date','author','owner','count','filecount');
foreach($params as $val)
{
	$arrows[$val]['asc']  = $sed_img_down;
	$arrows[$val]['desc'] = $sed_img_up;
}
$arrows[$s][$w]  = $sed_img_active[$w];

Asmo

Пн, 15 Вер 2008 23:54:46 -0000

Good decision.
I do not coder, but I try :)

But better this :)

$arrows = array();
$params = array('title','key','date','author','owner','count','filecount');
foreach($params as $val)
{
	$arrows[$val]['asc']  = $sed_img_down;
	$arrows[$val]['desc'] = $sed_img_up;
}

$arrow[$s]['asc'] = ($s && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$arrow[$s]['desc'] = ($s && $w=='desc') ? $sed_img_up_active : $sed_img_up;

Orkan

Пн, 15 Вер 2008 13:51:09 -0000

I like arrows highlighting :) ...but maybe in more compact way?

$arrows = array();
$params = array('title','key','date','author','owner','count','filecount');
foreach($params as $val)
{
	$arrows[$val]['asc']  = $sed_img_down;
	$arrows[$val]['desc'] = $sed_img_up;
}
$arrows[$s]['asc']  = $sed_img_down_active;
$arrows[$s]['desc'] = $sed_img_up_active;

Asmo

Нд, 14 Вер 2008 23:47:08 -0000

This improvement is clear extra variables in the URL string in the sorting and pagination, if they are not used. And add highlight active arrows in sorting bar.
This looks very interesting and + clear URL string.

// At the very top, before the hook list.first
$url_string     = "list.php?c=$c";
$sort_string   .= (!empty($s) && !empty($w)) ? "&s=$s&w=$w" : "";
$filter_string .= (!empty($o) && !empty($p)) ? "&o=$o&p=$p" : "";

Pagination:

$pagination = sed_pagination($url_string.$sort_string.$filter_string, $d, $totallines, $cfg['maxrowsperpage']);
list($pageprev, $pagenext) = sed_pagination_pn($url_string.$sort_string.$filter_string, $d, $totallines, $cfg['maxrowsperpage'], TRUE);

The next hack adds highlight active arrows in sorting bar

if (!$sed_cat[$c]['group'])
	{
	
	$sed_img_up_active   = "";
	$sed_img_down_active = "";
	
	$sed_img_title_down = ($s=='title' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
	$sed_img_title_up  = ($s=='title' && $w=='desc') ? $sed_img_up_active : $sed_img_up;

	$sed_img_key_down = ($s=='key' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
	$sed_img_key_up = ($s=='key' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
			
	$sed_img_date_down = ($s=='date' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
	$sed_img_date_up  = ($s=='date' && $w=='desc') ? $sed_img_up_active : $sed_img_up;

	$sed_img_author_down = ($s=='author' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
	$sed_img_author_up  = ($s=='author' && $w=='desc') ? $sed_img_up_active : $sed_img_up;

	$sed_img_owner_down = ($s=='owner' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
	$sed_img_owner_up  = ($s=='owner' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
			
	$sed_img_count_down = ($s=='count' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
	$sed_img_count_up = ($s=='count' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
	
	$sed_img_filecount_down = ($s=='filecount' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
	$sed_img_filecount_up = ($s=='filecount' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
		
	$t->assign(array(
	"LIST_TOP_CURRENTPAGE" => $currentpage,
	"LIST_TOP_TOTALLINES" => $totallines,
	"LIST_TOP_MAXPERPAGE" => $cfg['maxrowsperpage'],
	"LIST_TOP_TOTALPAGES" => $totalpages,
	"LIST_TOP_TITLE" => "$sed_img_title_down ".$L['Title']." 
	$sed_img_title_up",
	"LIST_TOP_KEY" => "$sed_img_down ".$L['Key']." 
	$sed_img_up",
	"LIST_TOP_DATE" => "$sed_img_date_down ".$L['Date']." 
	$sed_img_date_up",
	"LIST_TOP_AUTHOR" => "$sed_img_author_down ".$L['Author']." 
	$sed_img_author_up",
	"LIST_TOP_OWNER" => "$sed_img_owner_down ".$L['Owner']." 
	$sed_img_owner_up",
	"LIST_TOP_COUNT" => "$sed_img_count_down ".$L['Hits']." 
	$sed_img_count_up",
	"LIST_TOP_FILECOUNT" => "$sed_img_filecount_down ".$L['Hits']." 
	$sed_img_filecount_up"
		));
	}

You will also need to add two different colour images of arrows, for highlight
img/system/arrow-up-active.gif
img/system/arrow-down-active.gif

So, it looks very interesting and + clear URL string.

Heh, P.S. PFS and smiles not work Call to undefined function sed_htmlmetas()
Last core revision was very brutal :)