This improvement is clear extra variables in the URL string in the sorting and pagination, if they are not used. And add highlight active arrows in sorting bar.
This looks very interesting and + clear URL string.
// At the very top, before the hook list.first
$url_string = "list.php?c=$c";
$sort_string .= (!empty($s) && !empty($w)) ? "&s=$s&w=$w" : "";
$filter_string .= (!empty($o) && !empty($p)) ? "&o=$o&p=$p" : "";
Pagination:
$pagination = sed_pagination($url_string.$sort_string.$filter_string, $d, $totallines, $cfg['maxrowsperpage']);
list($pageprev, $pagenext) = sed_pagination_pn($url_string.$sort_string.$filter_string, $d, $totallines, $cfg['maxrowsperpage'], TRUE);
The next hack adds highlight active arrows in sorting bar
if (!$sed_cat[$c]['group'])
{
$sed_img_up_active = "<img src=\"skins/".$usr['skin']."/img/system/arrow-up-active.gif\" alt=\"\" />";
$sed_img_down_active = "<img src=\"skins/".$usr['skin']."/img/system/arrow-down-active.gif\" alt=\"\" />";
$sed_img_title_down = ($s=='title' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$sed_img_title_up = ($s=='title' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
$sed_img_key_down = ($s=='key' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$sed_img_key_up = ($s=='key' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
$sed_img_date_down = ($s=='date' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$sed_img_date_up = ($s=='date' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
$sed_img_author_down = ($s=='author' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$sed_img_author_up = ($s=='author' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
$sed_img_owner_down = ($s=='owner' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$sed_img_owner_up = ($s=='owner' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
$sed_img_count_down = ($s=='count' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$sed_img_count_up = ($s=='count' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
$sed_img_filecount_down = ($s=='filecount' && $w=='asc') ? $sed_img_down_active : $sed_img_down;
$sed_img_filecount_up = ($s=='filecount' && $w=='desc') ? $sed_img_up_active : $sed_img_up;
$t->assign(array(
"LIST_TOP_CURRENTPAGE" => $currentpage,
"LIST_TOP_TOTALLINES" => $totallines,
"LIST_TOP_MAXPERPAGE" => $cfg['maxrowsperpage'],
"LIST_TOP_TOTALPAGES" => $totalpages,
"LIST_TOP_TITLE" => "<a href=\"$url_string&s=title&w=asc$filter_string\">$sed_img_title_down</a> ".$L['Title']."
<a href=\"$url_string&s=title&w=desc$filter_string\">$sed_img_title_up</a>",
"LIST_TOP_KEY" => "<a href=\"$url_string&s=key&w=asc$filter_string\">$sed_img_down</a> ".$L['Key']."
<a href=\"$url_string&s=key&w=desc$filter_string\">$sed_img_up</a>",
"LIST_TOP_DATE" => "<a href=\"$url_string&s=date&w=asc$filter_string\">$sed_img_date_down</a> ".$L['Date']."
<a href=\"$url_string&s=date&w=desc$filter_string\">$sed_img_date_up</a>",
"LIST_TOP_AUTHOR" => "<a href=\"$url_string&s=author&w=asc$filter_string\">$sed_img_author_down</a> ".$L['Author']."
<a href=\"$url_string&s=author&w=desc$filter_string\">$sed_img_author_up</a>",
"LIST_TOP_OWNER" => "<a href=\"$url_string&s=ownerid&w=asc$filter_string\">$sed_img_owner_down</a> ".$L['Owner']."
<a href=\"$url_string&s=ownerid&w=desc$filter_string\">$sed_img_owner_up</a>",
"LIST_TOP_COUNT" => "<a href=\"$url_string&s=count&w=asc$filter_string\">$sed_img_count_down</a> ".$L['Hits']."
<a href=\"$url_string&s=count&w=desc$filter_string\">$sed_img_count_up</a>",
"LIST_TOP_FILECOUNT" => "<a href=\"$url_string&s=filecount&w=asc$filter_string\">$sed_img_filecount_down</a> ".$L['Hits']."
<a href=\"$url_string&s=filecount&w=desc$filter_string\">$sed_img_filecount_up</a>"
));
}
You will also need to add two different colour images of arrows, for highlight
img/system/arrow-up-active.gif
img/system/arrow-down-active.gif
So, it looks very interesting and + clear URL string.
Heh, P.S. PFS and smiles not work
Call to undefined function sed_htmlmetas()
Last core revision was very brutal :)