Форумы / Cotonti / Development / myfiles plugin is release ready

<<<123>>>

Release Candidate

Eugene
#16 03.02.2012 06:16

There is something I was waiting for so long!yes I really wish for this to be in Sienna and would like to help with it - if you need help... (maybe it would be easier to place it on GitHub?)

problems (under Siena with Genoa compatibility)

there are some mysql_query functions used in plug. In my case it tries to connect to DB with default user which has no right (myfiles.setup.php #44 & #64)... So, that means - if i even ignore mistakes in begging and try to work later - there is still no 'pff_path' column in DB.

It would be easier to use Cotonti API, I guess. Also, that would benefit later in converting to Siena version.

GHengeveld
#17 03.02.2012 09:21

I've tried to get ez to put it on Github before, but no success. If I'm going to help with the conversion I'll put it on Github myself. Version control and issue tracking is a must-have an Github provides the easiest solution for that.

Eugene
#18 03.02.2012 14:32
#33022 GHengeveld:

I've tried to get ez to put it on Github before, but no success. If I'm going to help with the conversion I'll put it on Github myself. Version control and issue tracking is a must-have an Github provides the easiest solution for that.

it is not "easy-type" plugin, but i would really like to see that part of Siena package. But I understand, it must be finished (or most finished) for Genoa first. Couse, it would be hard to fix bugs in GitHub (Siena) version without real tracking of Genoa changes. Am I right?

ez
#19 03.02.2012 19:01

Sorry.. Github is not my thing... I am not familiar with it.
I donated this code to cotonti so if sombody wants to put it on Github... be my guest.

Myfiles can be improved a lot like i allready said... But the codebase is very clear and it is divided into small parts so maintenance can be done easily.

Currently all overhead is stripped from myfiles for speed purposes.. So i use a lot of native mysql statements without a lot of EMPTY sed_xxx functions.
But a search / replace action can be done quite fast.

But thank you Eugene for liking my plugin :D.

It has been a lot of work to split up the old pfs code into pieces... (That code really was... shit and to complicated to work with)

==- I say: Keep it EZ -==
GHengeveld
#20 03.02.2012 19:42
@ez: I know it takes a while to get used to, if you prefer not to use it that's fine too. I know pfs code is a mess, I've worked with it before. Currently I'm working on the PM module which is a big mess too.
ez
#21 20.02.2012 21:31

Myfiles RC6 is out... more details can be found here : http://2basix.nl/page.php?al=cotonti-myfiles-plugin

Since the response is low this can mean a few things:

1) It is not used by anyone (that would be a shame)
2) There are no bugs found  :)
3) Not many sites uses Genoa 0.6.20 >



Either way I think i tested it quite good, I think, so it should be good to use.

I fixed a bug for PHP support, you must have (PHP 5 >= 5.2.0, PECL json >= 1.2.0) because I use JSON a lot.

have fun

==- I say: Keep it EZ -==
Отредактировано: ez (21.02.2012 07:08, 12 лет назад)
terracota
#22 20.02.2012 23:24
#33213 ez:

Myfiles RC6 is out... more details can be found here : http://2basix.nl/page.php?al=cotonti-myfiles-plugin

Great news! Thank you!

Логика и здравый смысл творят чудеса.
Logic and Sanity makes a real magic happens.
Eugene
#23 23.02.2012 07:53
#33213 ez:

3) Not many sites uses Genoa 0.6.20 >

YES. You got it. None of my web-sites using Genoa...

But to convert this to Siena better use last version. I have 2 customers right now which would appreciate this works in Siena well. I hope I'll find a time to invest in converting...

ez
#24 23.02.2012 10:47

Hi Eugene,

I can try to put back all sed_ functions for DB access... and hope that the compatibility plugin for Siena works ?

 

>>update : PM send with a version to try-out in siena

Added 1 day later:

some news on the myfiles front...

I am developing the folder as a list (as requested)

folderlistmode_494.png



Finished a version of myfiles WITH the folder list:

Myfiles 1.60 (2012-03-02)

 

==- I say: Keep it EZ -==
Отредактировано: ez (02.03.2012 19:59, 12 лет назад)
Eugene
#25 05.03.2012 10:27

I have roughly converted plugin to Siena to test. It installed well...

But I have problems with $db_pfs variable - as it obviously set in PFS module + it is declared under global in your functions - anyway it is empty...

The problem is more global than just plugin... I hope some of developpers may give advise.

ez
#26 05.03.2012 12:38

Shouldnt this be handled by the Genoa Compatibility plugin?
(I think there was a plugin for that...?)

I hope it will work.. so everybody  GENOA and SIENA  can use myfiles smiley

==- I say: Keep it EZ -==
Eugene
#27 05.03.2012 13:42

See, ez, I'm trying to convert it to Siena, not just run under Compatibility plugin...

ez
#28 05.03.2012 14:08

cool !

If you need help, or if something is not clear let me know

==- I say: Keep it EZ -==
Eugene
#29 15.03.2012 20:45

I'm working slowly as most of us who busy with other job...

but, finally, I converted myfiles to Siena. There were several changes required:

  • different JS embedding in header - not like in Genoa
  • different thumb making
  • some PDO stuff for mysql

I let myself to rewrite install part - it was very old...

I'm very interesting in seeing this plugin improved and polished for being natural part of Cotonti.

Ez, I really thank you for this plug and hope you gonna support it in both branches...

GHengeveld, I need your help very much in overseeing github version - cause, this is my first experience in hosting projects there...

P.S. It wasn't tested completely.

ez
#30 16.03.2012 06:53

I am very glad that you liked the plugin Eugene... And I am really glad you ported it into Siena.

I hope everybody can enjoy my plugin now... :D

As far as support, well see how that goes, i am not familiar with github, but I can try to make time to learn it

==- I say: Keep it EZ -==

<<<123>>>